fix: display conversation title in delete confirmation modal#11818
Merged
neubig merged 7 commits intoOpenHands:mainfrom Dec 31, 2025
Merged
fix: display conversation title in delete confirmation modal#11818neubig merged 7 commits intoOpenHands:mainfrom
neubig merged 7 commits intoOpenHands:mainfrom
Conversation
Collaborator
|
amanape will be available next week. I'll get him to take a look. Thank you! |
Collaborator
hieptl
reviewed
Dec 1, 2025
Contributor
Author
|
@hieptl |
hieptl
reviewed
Dec 8, 2025
42eb75c to
3b135be
Compare
hieptl
reviewed
Dec 10, 2025
Collaborator
hieptl
left a comment
There was a problem hiding this comment.
Hi @naaa760, I have verified the ticket locally, and the feature is working as expected. However, before approving and merging this pull request, could you please add tests for your changes? We are aiming to enforce stronger testing practices on the frontend. Thank you! 🙏
77f2fe8 to
b0a0d3b
Compare
Collaborator
|
Hello @naaa760, Could you please let me know if you are currently working on this pull request? Thank you! 🙏 |
amanape
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary of PR
Displays the conversation title in the delete confirmation modal so users can verify which conversation they're deleting.
Change Type
Checklist
Fixes
Resolves #11809