Skip to content

fix: display conversation title in delete confirmation modal#11818

Merged
neubig merged 7 commits intoOpenHands:mainfrom
nehaaprasad:feat/conv-conf-modl
Dec 31, 2025
Merged

fix: display conversation title in delete confirmation modal#11818
neubig merged 7 commits intoOpenHands:mainfrom
nehaaprasad:feat/conv-conf-modl

Conversation

@nehaaprasad
Copy link
Copy Markdown
Contributor

Summary of PR

Displays the conversation title in the delete confirmation modal so users can verify which conversation they're deleting.

Change Type

  • New feature

Checklist

  • I have read and reviewed the code and I understand what the code is doing.
  • I have tested the code to the best of my ability and ensured it works as expected.

Fixes

Resolves #11809

@nehaaprasad nehaaprasad requested a review from amanape as a code owner November 26, 2025 02:50
@mamoodi
Copy link
Copy Markdown
Collaborator

mamoodi commented Nov 26, 2025

amanape will be available next week. I'll get him to take a look. Thank you!

@hieptl
Copy link
Copy Markdown
Collaborator

hieptl commented Dec 1, 2025

Hi @naaa760, according to the image below, we can display the conversation title directly within the confirmation message instead of presenting it on a separate line.

issue1

For example, the confirmation message could be structured as follows.

Are you sure you want to delete the "Hello - Initial Greeting" conversation? This action cannot be undone.

Comment thread frontend/src/components/features/conversation-panel/conversation-panel.tsx Outdated
@nehaaprasad
Copy link
Copy Markdown
Contributor Author

@hieptl
please check it now!

Comment thread frontend/src/components/features/conversation-panel/confirm-delete-modal.tsx Outdated
Copy link
Copy Markdown
Collaborator

@hieptl hieptl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @naaa760, I have verified the ticket locally, and the feature is working as expected. However, before approving and merging this pull request, could you please add tests for your changes? We are aiming to enforce stronger testing practices on the frontend. Thank you! 🙏

@hieptl
Copy link
Copy Markdown
Collaborator

hieptl commented Dec 23, 2025

Hello @naaa760,

Could you please let me know if you are currently working on this pull request?

Thank you! 🙏

Copy link
Copy Markdown
Contributor

@amanape amanape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have simplified the test, and made a small style change to highlight the conversation title:

Image

@amanape amanape requested a review from hieptl December 30, 2025 14:09
Copy link
Copy Markdown
Collaborator

@hieptl hieptl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@neubig neubig merged commit 6f9c0aa into OpenHands:main Dec 31, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GUI] Show the Conversation Title on the Confirmation Modal Before Deleting

5 participants