Summary of PR

This PR enhances the robustness and test coverage of the StuckDetector by adding 6 new unit test cases for the _is_stuck_action_observation_pattern method.

Why this is needed: The existing test for this method only covered the "happy path" (the A-B-A-B pattern being successfully detected). The complex boolean logic in the D1 (len_check) and D2 (actions_equal) decisions was not being tested for independent failures.

These new tests implement Modified Condition/Decision Coverage (MC/DC), ensuring that each condition (CD1 through CD6) is shown to independently affect the decision's outcome.

Summary of Changes:

Adds 6 new tests to tests/unit/controller/test_stuck.py.

The tests validate the 3 MC/DC cases for the D1 Decision (length check).

The tests validate the 5 MC/DC cases for the D2 Decision (actions_equal), covering all pattern-breaking failures (e.g., test_fail_pattern_break_A6_A4).

Adds reusable event Mocks (Ap, Ai, Adp, etc.) to the top of the test file for readability.

Adds a lightweight fixture (stuck_detector_mcdc) to isolate these tests.

Result: All tests (new and old) are passing. The test count in the test_stuck.py file has increased from 22 to 28, confirming the robustness of the loop detection logic.

Change Type

• Bug fix
• New feature
• Breaking change
• Refactor
• Other (dependency update, docs, typo fixes, etc.)

Checklist

• I have read and reviewed the code and I understand what the code is doing.
• I have tested the code to the best of my ability and ensured it works as expected.

Fixes

Resolves #11599