To justify why this is necessary:

Analysis of frontend/src/api/git-service/git-service.api.ts Changes

The changes are appropriate and necessary for the Forgejo integration. Here's the breakdown:

What Changed:

// Before (main branch):
getBranches(repository, page, perPage) {
  return get(`/api/user/repository/branches?repository=${encodeURIComponent(repository)}&page=${page}&per_page=${perPage}`)
}

// After (Forgejo PR):
getBranches(repository, page, perPage, selectedProvider?) {
  return get(`/api/user/repository/branches`, {
    params: { repository, page, per_page: perPage, selected_provider: selectedProvider }
  })
}

Why This Is Needed:

1. Problem Being Solved: Without selected_provider, when fetching branches for a Forgejo repository, the backend would try GitHub first (and fail), then GitLab, etc. This causes unnecessary API calls and potential failures.

2. Consistency with Existing Pattern: The selected_provider parameter already exists on these endpoints in main:

   • get_user_repositories (line 70)
   • search_repositories (line 140)
   • search_branches (line 174)

   It was missing only from get_repository_branches (line 243), which this PR correctly adds.

3. Backend Changes: Commit de09fe3a4 added the corresponding backend support, threading selected_provider through to ProviderHandler.get_branches().

4. Code Quality Improvement: The change from inline URL string concatenation to using a params object is cleaner and less error-prone.

Related Commits in the PR:

• de09fe3a4 - Added selected_provider to backend endpoint
• ef6543a3e - Fixed ruff B008 linter errors by using Annotated[..., Query()] pattern (required because Query(default=None) as a default argument triggers the B008 rule about mutable default arguments)

Verdict: These changes are appropriate and follow existing patterns in the codebase.

Analysis of openhands/server/routes/git.py Changes

There are two distinct changes in this file:

1. Annotated[..., Query()] Pattern (commit ef6543a) - NECESSARY

Changed from:

selected_provider: ProviderType | None = None,

To:

selected_provider: Annotated[ProviderType | None, Query()] = None,

Why it's necessary: This fixes a ruff B008 error. The B008 rule warns against mutable default arguments in function calls. When you use Query() directly as a default value, it creates a new Query object at function definition time, which ruff flags. Using Annotated[..., Query()] is the modern FastAPI pattern that avoids this issue.

This change was made to 3 existing parameters (selected_provider in get_user_repositories, search_repositories, and search_branches).

2. Adding selected_provider to get_repository_branches (commit de09fe3) - NECESSARY for Forgejo

async def get_repository_branches(
    repository: str,
    page: int = 1,
    per_page: int = 30,
    selected_provider: Annotated[ProviderType | None, Query()] = None,  # NEW
    ...
)

Why it's necessary: This parameter was added to prevent GitHub fallback when fetching branches for Forgejo repositories. Without this, the system would try GitHub first and fail before falling back to Forgejo. This matches the pattern already used in other endpoints (search_repositories, search_branches).

Summary

Both changes should stay. They're not unnecessary - one is a lint fix and the other is essential for proper Forgejo provider routing.