Update serialization ID. Resolve some deprecation issues of Integer.

vitalijr2 · vitalijr2 · commit fc09db3fcf29 · 2023-09-14T14:45:04.000+03:00
diff --git a/core/src/test/java/feign/UtilTest.java b/core/src/test/java/feign/UtilTest.java
@@ -51,7 +51,7 @@ public void removesEmptyStrings() {
 
   @Test
   public void removesEvenNumbers() {
-    Integer[] values = new Integer[] {22, 23};
+    Integer[] values = {22, 23};
     assertThat(removeValues(values, number -> number % 2 == 0, Integer.class))
         .containsExactly(23);
   }
@@ -167,7 +167,7 @@ public void checkNotNullInputZeroNotNull0OutputZero() {
     // Act
     final Object retval = Util.checkNotNull(reference, errorMessageTemplate, errorMessageArgs);
     // Assert result
-    assertEquals(new Integer(0), retval);
+    assertEquals(0, retval);
   }
 
   @Test
diff --git a/hystrix/src/test/java/feign/hystrix/HystrixBuilderTest.java b/hystrix/src/test/java/feign/hystrix/HystrixBuilderTest.java
@@ -86,7 +86,7 @@ public void hystrixCommandInt() {
     final HystrixCommand<Integer> command = api.intCommand();
 
     assertThat(command).isNotNull();
-    assertThat(command.execute()).isEqualTo(new Integer(1));
+    assertThat(command.execute()).isEqualTo(Integer.valueOf(1));
   }
 
   @Test
@@ -98,7 +98,7 @@ public void hystrixCommandIntFallback() {
     final HystrixCommand<Integer> command = api.intCommand();
 
     assertThat(command).isNotNull();
-    assertThat(command.execute()).isEqualTo(new Integer(0));
+    assertThat(command.execute()).isEqualTo(Integer.valueOf(0));
   }
 
   @Test
@@ -250,7 +250,7 @@ public void rxObservableInt() {
     final TestSubscriber<Integer> testSubscriber = new TestSubscriber<Integer>();
     observable.subscribe(testSubscriber);
     testSubscriber.awaitTerminalEvent();
-    Assertions.assertThat(testSubscriber.getOnNextEvents().get(0)).isEqualTo(new Integer(1));
+    Assertions.assertThat(testSubscriber.getOnNextEvents().get(0)).isEqualTo(Integer.valueOf(1));
   }
 
   @Test
@@ -267,7 +267,7 @@ public void rxObservableIntFallback() {
     final TestSubscriber<Integer> testSubscriber = new TestSubscriber<Integer>();
     observable.subscribe(testSubscriber);
     testSubscriber.awaitTerminalEvent();
-    Assertions.assertThat(testSubscriber.getOnNextEvents().get(0)).isEqualTo(new Integer(0));
+    Assertions.assertThat(testSubscriber.getOnNextEvents().get(0)).isEqualTo(Integer.valueOf(0));
   }
 
   @Test
@@ -373,7 +373,7 @@ public void rxSingleInt() {
     final TestSubscriber<Integer> testSubscriber = new TestSubscriber<Integer>();
     single.subscribe(testSubscriber);
     testSubscriber.awaitTerminalEvent();
-    Assertions.assertThat(testSubscriber.getOnNextEvents().get(0)).isEqualTo(new Integer(1));
+    Assertions.assertThat(testSubscriber.getOnNextEvents().get(0)).isEqualTo(Integer.valueOf(1));
   }
 
   @Test
@@ -390,7 +390,7 @@ public void rxSingleIntFallback() {
     final TestSubscriber<Integer> testSubscriber = new TestSubscriber<Integer>();
     single.subscribe(testSubscriber);
     testSubscriber.awaitTerminalEvent();
-    Assertions.assertThat(testSubscriber.getOnNextEvents().get(0)).isEqualTo(new Integer(0));
+    Assertions.assertThat(testSubscriber.getOnNextEvents().get(0)).isEqualTo(Integer.valueOf(0));
   }
 
   @Test
diff --git a/jaxrs2/src/main/java/feign/jaxrs2/JAXRSClient.java b/jaxrs2/src/main/java/feign/jaxrs2/JAXRSClient.java
@@ -86,7 +86,7 @@ private Integer integerHeader(Response response, String header) {
     }
 
     try {
-      return new Integer(headers.getFirst(header));
+      return Integer.valueOf(headers.getFirst(header));
     } catch (final NumberFormatException e) {
       // not a number or too big to fit Integer
       return null;
diff --git a/pom.xml b/pom.xml
@@ -637,6 +637,8 @@
             <exclude>NOTICE</exclude>
             <exclude>OSSMETADATA</exclude>
             <exclude>**/*.md</exclude>
+            <exclude>**/*.asciidoc</exclude>
+            <exclude>**/*.iuml</exclude>
             <exclude>bnd.bnd</exclude>
             <exclude>travis/**</exclude>
             <exclude>src/test/resources/**</exclude>

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ private Integer integerHeader(Response response, String header) {`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`try {`
`89`		`- return new Integer(headers.getFirst(header));`
	`89`	`+ return Integer.valueOf(headers.getFirst(header));`
`90`	`90`	`} catch (final NumberFormatException e) {`
`91`	`91`	`// not a number or too big to fit Integer`
`92`	`92`	`return null;`