HD: Switched to an equivalent but numerically more reliable expression for the hydrostatic moment on (partially wetted) circular endplates #2941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n for the hydrostatic moment on (partially wetted) circular endplates
…static load calculations.
andrew-platt
approved these changes
Aug 4, 2025
Collaborator
andrew-platt
left a comment
There was a problem hiding this comment.
Approving after our conversation about the method of derivation (I haven't verified it myself).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
The previous expression for the hydrostatic moment on a circular member endplate can occasionally give inaccurate/incorrect results due to a numerical precision problem caused by dividing a number that is very close to zero. This PR replaces the old expression with an equivalent but more reliable one that completely avoids the possibility of division by zero.
Impacted areas of the software
HydroDyn
Test results, if applicable
No change to existing test results.