Minor fixes for v4.1 #2891
Merged
Minor fixes for v4.1 #2891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re any ATTRIBUTE statements
Collaborator
|
@gbarter That's a really strange bug with the |
…to duplicate in the subroutines
Contributor
Author
|
Thanks, Derek. That seems to have worked. Relevant PR on the conda feedstock is here. |
mayankchetan
approved these changes
Jul 1, 2025
Contributor
mayankchetan
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for the fix @gbarter!
andrew-platt
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Two small bug fixes:
FAST_directoryis not set results in errors since the default value isNone(instead of an empty string). I kept theNonedefault value, but added a check for it.Not sure if this PR should be directed to the
devbranch, or therc4.1.1branch.Related issue, if one exists
Impacted areas of the software
Additional supporting information
Test results, if applicable