Gh actions debug #2883
Merged
Gh actions debug #2883
+176
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the working directory issue in the Python regression test GitHub action by switching from runner.workspace to github.workspace, and updates caching to use artifacts instead of the actions/cache mechanism.
- Updated working directory references throughout the workflow
- Replaced caching with artifact upload/download to share build outputs between jobs
Add space for clarity Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
andrew-platt
left a comment
There was a problem hiding this comment.
Looks good and tests ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
This PR fixes the issue with Python not being able to find the
requirements.txtfile in the regression test GitHub action. The issue was caused by not specifying or using the wrong variable for the working directory when runningpip install -r requirements.txt. Different runners would interpret the working directory differently causing tests to sometimes pass and sometimes fail. This PR uses${{github.workspace}}instead of${{runner.workspace}}to specify the working directory.In addition, the existing regression test GitHub action uses caches to transfer data and binaries between the jobs in a run. Based on https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/storing-and-sharing-data-from-a-workflow#comparing-artifacts-and-dependency-caching, artifacts should be used for sharing data within a run (across jobs) and caches should be used for sharing dependencies across workflow runs. This PR changes the action to use artifacts, which reduces storage size and makes it possible for the user to download the compilation output after the run, which may be useful.
Related issue, if one exists
Impacted areas of the software
automated-dev-tests.yml