ADI: adilib was getting included in aerodynlib #2136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adilib really should be built separately and linked only into the driver and c-bindings interfaces. Discovered this while investigating a compiler segfault with Intel OneAPI 2023.2 with LLVM while compiling AeroDyn_Inflow.f90
662fef0 to
7281803
Compare
deslaughter
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to merge
Feature or improvement description
adilibreally should be built separately and linked only into the driver and c-bindings interfaces.Discovered this while investigating a compiler segfault with Intel OneAPI 2023.2 with LLVM while compiling
AeroDyn_Inflow.f90(issue #2135).Related issue, if one exists
Maybe related to #2135
Impacted areas of the software
CMake build processes only.
Additional supporting information
This should be ported to 3.5.3 as well.
Test results, if applicable
No tests are affected.