Skip to content

Use AD tower diameter for VTK visualization + minor improvements #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrew-platt merged 8 commits into from
Jan 12, 2024
Merged

Use AD tower diameter for VTK visualization + minor improvements #1973

andrew-platt merged 8 commits into from
Jan 12, 2024

Conversation

@bjonkman
Copy link
Contributor

@bjonkman bjonkman commented Jan 11, 2024

This PR is ready to be merged.

Feature or improvement description

  • If AeroDyn has tower diameter information, that is used for VTK visualization of the tower surface. Otherwise, it will use a tower diameter based on the NREL 5MW turbine (like it did before).
  • The Registry now prints an error message before ending if a data type that should only contain reals finds an invalid type.
  • Removed unnecessary dependency on SeaState in HydroDyn.
  • Fixed some typos:
    • The word "Boeing" was misspelled in a few places.
    • The NWTC Library was potentially using the wrong number of bytes in some of its error messages if an array couldn't be allocated.
    • A line computing an index was repeated twice in FAST_Lin (likely a result of a merge).
    • I changed the case of the variable "l" to "L" for readability (it's easy to confuse lower-case l with the number 1 in some fonts)

Related issue, if one exists
None

Impacted areas of the software

  • Tower surface VTK visualization
  • Some error messages throughout the code

Test results, if applicable
This does not change any test-case results. Only cases with AeroDyn tower diameter with VTK surfaces would look any different, but we don't have those kinds of tests.

@bjonkman
minor updates to comments
9902d90 
- removed readme file that doesn't apply any more
- removed SeaSt module dependence from HD (it already uses SeaSt_WaveField)
@bjonkman
VTK: use AD tower for visualization, if available
db50261
@bjonkman
minor cleanup
d0a338b 
- I'm not a fan of variables named with lower-case "l", so I made them upper case "L". This is less likely to be confused with the number "1"
- registry now gives an error message before ending when data types contain invalid types
@bjonkman
NWTC Library: fix memory size printed in some error statements
37f7da5 
in some cases, default reals were used instead of double or single, so the error messages when not able to allocate some variables could have been incorrect
@bjonkman
VTK fix: use existing TowerDiam instead of TowerRad
860cd62
@bjonkman
Fix typos in spelling Boeing
ae10f78
@andrew-platt andrew-platt self-assigned this Jan 11, 2024
@andrew-platt andrew-platt added this to the v4.0.0 milestone Jan 11, 2024
@andrew-platt
Copy link
Collaborator

andrew-platt commented Jan 11, 2024 •
edited
Loading

Thanks for adding this feature!

@bjonkman
Fix for OpenFAST/AD_InitOut variables
4a2a697
@bjonkman
Windows: Replace system calls with equivalent Fortran/C calls
d120344 
Fix intermittent failure of `system` commands on Windows: occasionally the system calls would fail to finish and make the program hang or end prematurely without any error message.
@andrew-platt andrew-platt requested review from deslaughter and removed request for deslaughter January 12, 2024 00:44
@andrew-platt andrew-platt merged commit 4460f39 into OpenFAST:dev-unstable-pointers Jan 12, 2024
@bjonkman
Copy link
Contributor Author

bjonkman commented Jan 12, 2024

I ran the OpenFAST IEA_LB_RWT-AeroAcoustics r-test with VTK output both with and without the tower points defined in AD15. I chose this model only because it's not the NREL 5MW and it had blade surface data defined already. Here are the two plots (note, it seems like the blade airfoil coordinate files here have an error in their x-y coordinate of airfoil reference definition, causing the blades to look off [not centered] in these plots).

  1. tower defined using 5MW proportions:
    image

  2. tower defined using TwrElev and TwrDiam from the AD15 file (note, I modified the tower elevation in the AD15 input file a little since ED defined the tower to be 110 m, but AD had it set to 140 m height).
    image

@andrew-platt andrew-platt mentioned this pull request Jan 19, 2024
Closed
@andrew-platt andrew-platt mentioned this pull request May 9, 2024
Merged
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
Merged
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrew-platt andrew-platt andrew-platt approved these changes

Assignees

@andrew-platt andrew-platt

Labels

Module: AeroDyn Type: Enhancement

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bjonkman @andrew-platt