Merged
Conversation
neboat
requested changes
Jan 1, 2025
Collaborator
neboat
left a comment
There was a problem hiding this comment.
Thank you for submitting this PR! I'm super excited to add this new feature to Cilk, and I'm delighted to see this revival and fixup of PR #55.
This PR also gives us a great opportunity to work on our processes for accepting external contributions, which I appreciate!
I've done some simple tests of these Cilk for-range loops on my local system, and they seem to work well.
I have just a couple minor requests:
- GitHub can annotate multiauthor commits in the history, but it needs the email addresses of the coauthors to do so. I believe that something like the following should work:
Please update the Co-authored-by lines in the first commit with those email addresses. Hopefully GitHub will recognize the coauthors properly.
Co-authored-by: Sualeh Asif <sualehasif996@gmail.com> Co-authored-by: Arvid Lunnemark <arvid.lunnemark@gmail.com> - Please address the minor comments I've left on the code itself.
Once those are addressed, I'm happy to accept this PR. Please let me know if you have questions or concerns.
Thanks again!
Co-authored-by: Sualeh Asif <sualehasif996@gmail.com> Co-authored-by: Arvid Lunnemark <arvid.lunnemark@gmail.com>
neboat
approved these changes
Jan 3, 2025
Collaborator
neboat
left a comment
There was a problem hiding this comment.
These changes look good to me. Thanks!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored by arvid220u and sualehasif