Merged
Conversation
When playing a playlist and reaching the end of a track, the vorbis decoder was never set to the beginning of the file again for the next loop of a playlist. This meant that each music file would only ever play once, and then when tried to play again be considered at the end and immediately switch to the end. If there are no more valid files in the playlist and all are at the end, this would wedge the audio thread, causing no sound and the next interaction with the audio lock (like, for example, the sfx from clicking a button) would hardlock the game.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When playing a playlist and reaching the end of a track, the vorbis decoder was never set to the beginning of the file again for the next loop of a playlist.
This meant that each music file would only ever play once, and then when tried to play again be considered at the end and immediately switch to the end.
If there are no more valid files in the playlist and all are at the end, this would wedge the audio thread, causing no sound and the next interaction with the audio lock (like, for example, the sfx from clicking a button) would hardlock the game.