Cleanup battle location management#1542
Merged
FilmBoy84 merged 1 commit intoOpenApoc:masterfrom Jul 11, 2025
Merged
Conversation
Rather than casting between string IDs and StateRef<Building> and StateRef<Vehicle> all the time just store the StateRefs directly. NOTE: This will break saves if you have an ongoing battle
035a6a3 to
98597c3
Compare
Collaborator
|
Not had any issues with this
No issues found :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A code cleanup split out of some ongoing re-work of StateRef<> stuff, shouldn't cause any functional changes - Except it'll change the save format slightly breaking saves if you have an ongoing battle
Rather than casting between string IDs and StateRef and StateRef all the time just store the StateRefs directly, as typed objects tend to be less error-prone.