Merged
Conversation
JonnyH
approved these changes
Feb 28, 2025
Collaborator
JonnyH
left a comment
There was a problem hiding this comment.
Looks good.
Would we want this changeable in game too? But that can be done later if needed.
And the UI xml has a lot of churn, but I guess that's just what the qt editor does.
Contributor
Author
|
Someday, when the options menu is improved, I hope all the launcher options can be added. |
Collaborator
|
LGTM and functions as intended - merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw that OpenXcom had this and thought it would be a good addition.