Fix message history screen scrolling#1138
Merged
FilmBoy84 merged 1 commit intoOpenApoc:masterfrom Mar 26, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #546.
It would appear that when the ScrollBar is created in the MessageLogScreen, it uses the original Maximum value of 10 that is assigned by default. When calling the scrollMax function, it was only scrolling down by 10. This was verified by increasing this initial Maximum value and observing the ScrollBar scroll further down the message history screen. This PR fixes this problem by calling the MessageLogScreen::update function to obtain the correct Maximum value before calling scrollMax.