Skip to content

Agents transferred or fired are not correctly removed from their current research/work projects leading to an error #1559

@FilmBoy84

Description

@FilmBoy84

Describe the bug
Discord user Silverhaze provided the following savegame under OpenApoc 20250822

Pre-fix Save 1.zip

The save will not load due to an error with AGENT_245

I unpacked the save and removed all entries relating to AGENT_245 from agents.xml , research.xml and buildings.xml before repacking into the save

On running the game and loading the fixed save time appeared to run, however, going immediately to "quit game" after running a few seconds, i received another error with AGENT_241

I repeated the clean process for this agent ID, repacked the save, and loaded the game, ran time on a few seconds and went to quit, whereup I was again faced with an error for AGENT_232

The clean, repack, and load game process was done for a further two cycles afterwards removing AGENT_355 and AGENT_356 respectively before the save would load, run a few seconds and then quit without error

Expected behavior
After removing all agent IDs relating to 245, 241, 232, 355 and 356 from the above save, the game will run and quit without issue as attached below:

post-fix 1.zip

However, the agents that were transferred are also removed - losing those agents

Really the game needs to act as the original game - as soon as agents are transferred or fired (i.e. on the confirmation request button click) any work or research assigned to the affected agents is cleared, any craft they may be in they are taken off the roster for, and they are either transferred or returned to the city / destroyed as normal

Settings CONF attached for 20250822

OpenApoc_settings.zip

Metadata

Metadata

Assignees

No one assigned

    Labels

    !BUG! HIGH PRIORITYCrashes the game! A serious issue stopping game progress or losing data. Needs a fix finding ASAP!Agent ID ErrorA label for tracking all issues relating to this long standing Agents/Scientists related crashCityscapeAn issue relating to something in the City overview part of ApocalypseCode QuerySomething doesn't seem right in the code. It may not be a bug, but it probably needs fixing!Marketplace / EconomySomething that affects transactions or behaviour or logic in the Marketplace or Economy screensResearch / ScientistsSomething relating to research and / or scientistsRoadmapA an issue containing features that need to be completed for a "full" gaming experience.Verified / ReplicatedThis issue has been verified or replicated by a developer

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions