Fixes for v3.0.1#366
Merged
Merged
Conversation
earonesty
suggested changes
Jul 14, 2023
| const chats = getSnapshot(self.privMessages) | ||
| chats.forEach((chat) => { | ||
| if (chat.pubkey === self.pubkey) { | ||
| chat.pubkey = chat.tags.find((el) => el[0] === "p")[1] |
Contributor
There was a problem hiding this comment.
the tag is the recipient, pubkey is sender.
now you don't know who sent the message
no way this can render right
Contributor
Author
There was a problem hiding this comment.
it render fine, it made it for this case
(Home Screen)
current user -> send message to A -> A not response -> last message display in home screen is current user
current user -> send message to B -> B not response -> last message display in home screen is current user too
so I made it get recipient for this case to prevent duplicate items in home screen, and ignore the rest
message's content will not change, this behavior similar to telegram too
This was referenced Jul 18, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes