Create override for array schema default value when using the spring …#894
Open
jason-cohen wants to merge 1 commit intoOpenAPITools:masterfrom
Open
Create override for array schema default value when using the spring …#894jason-cohen wants to merge 1 commit intoOpenAPITools:masterfrom
jason-cohen wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
Member
|
@jason-cohen LGTM. Just a question: If swagger-parser fixes the issue, will it create a regression or it will still work regardless? |
Contributor
Author
|
@JFCote I had a bit of a back-and-forth with the members of swagger-parser, and I think this PR would need to be revised. Simply performing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…codegen.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.Description of the PR
Fix #890
Note
There is an issue with the swagger-parser (swagger-api/swagger-parser#814) where an empty string for the default field is parsed as null. This fix won't achieve the desired effect until that issue is resolved and released.