Stackoverflow in toExampleValue() for python client#8326
Merged
spacether merged 1 commit intoOpenAPITools:masterfrom Jan 5, 2021
Merged
Stackoverflow in toExampleValue() for python client#8326spacether merged 1 commit intoOpenAPITools:masterfrom
spacether merged 1 commit intoOpenAPITools:masterfrom
Conversation
Added a Set<String> in toExampleValueRecursive() to keep track of which models we have generated to avoid an infinite recursion for recursive models. An example of a recursive model would be a GeoJson GeometryCollection.
Contributor
|
Thanks for the new PR! What code did you change to fix the line end issue? |
6 tasks
Contributor
Author
|
@spacether Yes, that was it. Sorry, I try to rebase/squash on my side (habit at my day job). |
Contributor
|
Closing and re-opening to try to kick off travis |
spacether
approved these changes
Jan 5, 2021
Contributor
spacether
left a comment
There was a problem hiding this comment.
Thank you for your new PR with the fix!
Merging here and keeping an eye on CI tests...
spacether
reviewed
Jan 5, 2021
modules/openapi-generator/src/test/java/org/openapitools/codegen/python/PythonClientTest.java
Show resolved
Hide resolved
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a Set in toExampleValueRecursive() to keep track of which models we have
generated to avoid an infinite recursion for recursive models. An example of a recursive
model would be a GeoJson GeometryCollection.
@spacether This is a retry of the prior PR that was reverted due to an OS line ending issue.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master,5.1.x,6.0.x