[typescript-axios] Serialize complex type in multipart/form-data as JSON#7816
Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom Nov 3, 2020
Conversation
…SON (OpenAPITools#7658) Complex types need to be serialized as JSON to avoid FormData.append() from converting them into strings through .toString().
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Contributor
|
Does this also need the generated ToJSON mapper function or is the Axios path different? |
Contributor
Author
|
It worked perfectly without the TOJSON mapper. Can you explain why would it be needed? |
Contributor
The |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complex types need to be serialized as JSON to avoid FormData.append() from converting them into strings through .toString().
Fixes #7658 for typescript-axios
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)