Skip to content

[bug][kotlin] Better escaping of var names#7598

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
jimschubert:kotlin-headers
Oct 5, 2020
Merged

[bug][kotlin] Better escaping of var names#7598
wing328 merged 1 commit intoOpenAPITools:masterfrom
jimschubert:kotlin-headers

Conversation

@jimschubert
Copy link
Member

fixes #7322
Kotlin escaping should follow similar pattern to other generators, by escaping the regex sanitization before language-specific sanitize.

cc @agilob
cc @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][Kotlin] The character '-' in request headers replaced with 'Minus'

3 participants