Skip to content

Fix scala-sttp enum generation#7432

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
acgray:master
Sep 18, 2020
Merged

Fix scala-sttp enum generation#7432
wing328 merged 2 commits intoOpenAPITools:masterfrom
acgray:master

Conversation

@acgray
Copy link

@acgray acgray commented Sep 16, 2020

To fix #7431

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @clasnake @jimschubert @shijinkui @ramzimaalej @chameleon82 @Bouillie

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and the petstore client compiles without issues.

@wing328 wing328 changed the title #7431 fix sttp enum generation Fix scala-sttp enum generation Sep 18, 2020
@wing328 wing328 merged commit 7424489 into OpenAPITools:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Scala Sttp Codegen generates empty case class for named enums

2 participants