Skip to content

[typescript-angular] Fix date-timing-parsing is truncating the time#4792

Merged
macjohnny merged 6 commits intoOpenAPITools:masterfrom
Xambey:fix_issue_4623
Dec 18, 2019
Merged

[typescript-angular] Fix date-timing-parsing is truncating the time#4792
macjohnny merged 6 commits intoOpenAPITools:masterfrom
Xambey:fix_issue_4623

Conversation

@Xambey
Copy link
Contributor

@Xambey Xambey commented Dec 14, 2019

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Fixes problems with truncating time in DateTime when converting to ISO format in typescript client for required method parameters. (This does not apply to dates without time).
Fixes #4623
See #4763

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11)

Copy link

@batousik batousik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, merge pls

@macjohnny macjohnny added this to the 4.2.3 milestone Dec 18, 2019
@macjohnny macjohnny merged commit 52d3844 into OpenAPITools:master Dec 18, 2019
@wing328 wing328 changed the title fix(typescript-angular): Fix date-timing-parsing is truncating the time (#4623 #4763) [typescript-angular] Fix date-timing-parsing is truncating the time Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][TYPESCRIPT] date-timing-parsing is truncating the time

3 participants