[go-experimental] Support selection and formatting of endpoint servers#4755
Merged
jimschubert merged 6 commits intoOpenAPITools:masterfrom Dec 18, 2019
Merged
Conversation
e01a59b to
0ec2f5f
Compare
jirikuncar
commented
Dec 11, 2019
modules/openapi-generator/src/main/resources/go-experimental/configuration.mustache
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Should I create the same patch also for |
Contributor
Author
d6205a0 to
d7ff24b
Compare
Contributor
|
This looks good to me ! thanks @jirikuncar |
bkabrda
suggested changes
Dec 16, 2019
Contributor
bkabrda
left a comment
There was a problem hiding this comment.
This looks really great overall. I left couple minor comments to fix, mostly improving error messages. We will also need to document this properly so that users know how to use all this functionality from the autogenerated docs.
As for including this in the stable go templates, I don't think we should do that. It breaks API of the generated clients (e.g. it removes Configuration.BasePath), so that's a no-go.
modules/openapi-generator/src/main/resources/go-experimental/configuration.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/go-experimental/configuration.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/go-experimental/configuration.mustache
Outdated
Show resolved
Hide resolved
modules/openapi-generator/src/main/resources/go-experimental/configuration.mustache
Outdated
Show resolved
Hide resolved
fc8ea67 to
22bc388
Compare
bkabrda
approved these changes
Dec 16, 2019
Contributor
bkabrda
left a comment
There was a problem hiding this comment.
LGTM now (assuming CI run passes :)). Thanks!
Contributor
Author
|
All green 🎉 @wing328 🙏 |
Member
|
Thanks! This looks awesome and I'm looking forward to seeing positive use cases in the wild. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support selection and formatting of endpoint servers using context.
Addresses #590
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.cc @antihax (2017/11) @bvwells (2017/12) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)