Merged
Conversation
Contributor
Author
|
I've checked that the values are available in mustache files. (PHP)
{{#allParams}}
+ {{#style}}var_dump('{{style}}');{{/style}}
+ var_dump({{isExplode}});
{{/allParams}}
protected function testQueryParameterCollectionFormatRequest($pipe, $ioutil, $http, $url, $context)
{
var_dump('form');
var_dump(true); |
Contributor
Author
|
cc @OpenAPITools/generator-core-team |
wing328
reviewed
Oct 15, 2019
| public boolean isFormParam, isQueryParam, isPathParam, isHeaderParam, | ||
| isCookieParam, isBodyParam, hasMore, isContainer, | ||
| secondaryParam, isCollectionFormatMulti, isPrimitiveType, isModel; | ||
| secondaryParam, isCollectionFormatMulti, isPrimitiveType, isModel, shouldExplode; |
Member
There was a problem hiding this comment.
@ackintosh thanks for the PR. What about using isExplode to follow the naming convention of other boolean flags?
cc @OpenAPITools/generator-core-team
Member
There was a problem hiding this comment.
Please update the following functions to include the new property:
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing it out!
Contributor
Author
There was a problem hiding this comment.
Updated the comment according to the renaming.
#4042 (comment)
Member
|
CircleCI failure not related to this change. |
4 tasks
Member
|
@ackintosh thanks for the PR, which has been included in v4.2.0 release: https://twitter.com/oas_generator/status/1189824932345069569 |
This was referenced Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
Related issue: #4039
In order to provide better collection serialization support, add
styleandexplodeattributes to CodegenParameter.