[java][client] Add a "serializationLibrary" option#3759
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Aug 28, 2019
Merged
[java][client] Add a "serializationLibrary" option#3759wing328 merged 3 commits intoOpenAPITools:masterfrom
wing328 merged 3 commits intoOpenAPITools:masterfrom
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Member
|
Similar PR: #3734 Suggestion: either using serializationLibrary or serializationEngine for consistency |
Contributor
parachutemind
added a commit
to parachutemind/openapi-generator
that referenced
this pull request
Aug 26, 2019
…ngine to serializationLibrary Fixed the data class mustache template to not add an extra line between the @entity and the variable name Regenerated petstore samples
…tion-library-option
wing328
approved these changes
Aug 28, 2019
Member
wing328
left a comment
There was a problem hiding this comment.
LGTM (have not tested it locally)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
To support both
gsonandjacksonwith the java-client generator using therest-assuredlibrary, we need to come up with a solution to be able to select theserializationLibrary.As discussed with @jimschubert on Slack a new flag is introduced for that:
serializationLibrary.If a given library supports only one "serializationLibrary" (all generator for now), the value set by the user is ignored.
This is similar to the
dateLibraryoption, where the user can decide which date library to use independently from thelibrary.