Skip to content

autoupdating generator script: userdef cache dir#3631

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
RonnyPfannschmidt:patch-1
Aug 17, 2019
Merged

autoupdating generator script: userdef cache dir#3631
wing328 merged 1 commit intoOpenAPITools:masterfrom
RonnyPfannschmidt:patch-1

Conversation

@RonnyPfannschmidt
Copy link
Contributor

@RonnyPfannschmidt RonnyPfannschmidt commented Aug 13, 2019

with this addition the script should be able to store the jars at a user-defined folder if desired

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

with this addition the script should be able to store the jars at a user-defined folder if desired
@RonnyPfannschmidt
Copy link
Contributor Author

finished testing this locally and it works as i intended

@wing328
Copy link
Member

wing328 commented Aug 15, 2019

@RonnyPfannschmidt thanks for the PR.

cc @jimschubert (the author of the script)

@wing328 wing328 added this to the 4.1.1 milestone Aug 15, 2019
@wing328 wing328 merged commit aa4ead2 into OpenAPITools:master Aug 17, 2019
@wing328
Copy link
Member

wing328 commented Aug 17, 2019

@RonnyPfannschmidt PR merged into master. Thanks for your contribution.

@wing328
Copy link
Member

wing328 commented Aug 26, 2019

@RonnyPfannschmidt thanks again for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants