@tsiq-jeremy thanks for your PR! can you please re-generate the samples?

Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.

cc @nicokoenig

Hey I just ran ./bin/typescript-axios-petstore-all.sh and did not see any changes when running git status. I looked through the yaml file it runs against and it has date-time, but no date types.

@tsiq-jeremy ok, that's probably because there is no Date-query parameter in the petstore example, so everything is fine.
The CI-failure is unrelated.

@tsiq-jeremy would you like to fix the same problem in the typescript-fetch generator, i.e. here:

Hey, let me look into that one. I'm not sure if there is a problem with typescript-fetch b/c in modelGeneric.mustache it has FromJSON and ToJSON that are manipulating the date type.

yes, but I think the From/ToJson functions are used for the body, not for the query parameters, so it should be the same situation

Hey I have not tested this out fully, but I think this should not be a problem with typescript-fetch. Used to test:

        "parameters": [
          {
            "name": "date",
            "in": "query",
            "type": "string",
            "format": "date"
          }
        ]

Produced:

export interface GetOrderByIdRequest {
    date: Date;
}

   ....
    async getOrderByIdRaw(requestParameters: GetOrderByIdRequest): Promise<runtime.ApiResponse<Order>> {
       ....
        const queryParameters: runtime.HTTPQuery = {};

        if (requestParameters.date !== undefined) {
            queryParameters['date'] =  (requestParameters.date as any).toISOString().substr(0,10);
        }
       ...
    }

So it looks like that a Date object is getting passed in so that it should not produce an error when calling toISOString.

Ok, alright, thanks for checking!

@tsiq-jeremy thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553