Skip to content

Update C# client dependency#2678

Merged
wing328 merged 9 commits intomasterfrom
csharp-update2
Jun 3, 2019
Merged

Update C# client dependency#2678
wing328 merged 9 commits intomasterfrom
csharp-update2

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Apr 16, 2019 •
edited
Loading

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Update C# client dependency (nunit, jsonsubtypes, Newtonsoft.Json, etc)

cc @mandrean (2017/08), @jimschubert (2017/09) 

@wing328 wing328 added this to the 4.0.0 milestone Apr 16, 2019
@jimschubert
Copy link
Member

jimschubert commented Apr 16, 2019

I support upgrading!

Did you test this across supported framework versions? I recall there was an issue with newer versions of either JSON.net or the subtypes package (possibly both), which had issues with one or more of our framework options.

The errors were only presented at runtime.

@wing328
Copy link
Member Author

wing328 commented May 7, 2019

Did you test this across supported framework versions?

I didn't. I only leverage the AppVeyor to test the change at the moment. Agreed with you that we need to test more thoroughly with different frameworks.

@wing328
Copy link
Member Author

wing328 commented May 9, 2019

Tests running fine locally but in Appveyor, it couldn't find nunit dll:

Project "C:\projects\openapi-generator\samples\client\petstore\csharp\OpenAPIClient\Org.OpenAPITools.sln" (1) is building "C:\projects\openapi-generator\samples\client\petstore\csharp\OpenAPIClient\src\Org.OpenAPITools.Test\Org.OpenAPITools.Test.csproj" (3) on node 1 (default targets).
PrepareForBuild:
  Creating directory "bin\Debug\".
  Creating directory "obj\Debug\".
ResolveAssemblyReferences:
  Primary reference "nunit.framework".
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\MSBuild\15.0\Bin\Microsoft.Common.CurrentVersion.targets(2110,5): warning MSB3245: Could not resolve this reference. Could not locate the assembly "nunit.framework". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors. [C:\projects\openapi-generator\samples\client\petstore\csharp\OpenAPIClient\src\Org.OpenAPITools.Test\Org.OpenAPITools.Test.csproj]
          For SearchPath "{HintPathFromItem}".
          Considered "..\..\packages\NUnit.3.11.0\lib\nunit.framework.dll", but it didn't exist.
          For SearchPath "{TargetFrameworkDirectory}".
          Considered "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5\nunit.framework.winmd", but it didn't exist.
          Considered "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5\nunit.framework.dll", but it didn't exist.
          Considered "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.5\nunit.framework.exe", but it didn't exist.

Anyone has seen something similar before?

@wing328
Copy link
Member Author

wing328 commented May 9, 2019

NUnit 3.11 is the latest version: https://nunit.org/download/

@wing328 wing328 modified the milestones: 4.0.0, 4.0.1 May 13, 2019
@wing328
Copy link
Member Author

wing328 commented May 27, 2019

@jimschubert finally I'm able to fix the issue and all tests passed.

@wing328 wing328 removed the WIP Work in Progress label May 27, 2019
@wing328 wing328 modified the milestones: 4.0.1, 4.0.2 May 31, 2019
@wing328 wing328 merged commit e06a408 into master Jun 3, 2019
@wing328 wing328 deleted the csharp-update2 branch June 3, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Client: C-Sharp Enhancement: Compatibility

Projects

None yet

Milestone

4.0.2

Development

Successfully merging this pull request may close these issues.

2 participants

@wing328 @jimschubert