[Bug][Python]Support body as bytes when Content-Type is unknown#2626
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Apr 26, 2019
sarod:issue#2623
Merged
[Bug][Python]Support body as bytes when Content-Type is unknown#2626wing328 merged 3 commits intoOpenAPITools:masterfrom sarod:issue#2623
wing328 merged 3 commits intoOpenAPITools:masterfrom
sarod:issue#2623
Conversation
Contributor
Author
sarod
commented
Apr 8, 2019
Contributor
Author
There was a problem hiding this comment.
This comment should probably be updated but I'm not sure I understand the last part 'when body argument is provided in serialized form' so I chose to let it untouched for now.
Member
There was a problem hiding this comment.
@sarod My "guess" is that the body can simply a string, e.g. "OK" or a boolean value (e.g. true), or just an integer, e.g. 2019.
Usually, the HTTP request body is JSON payload and I did see a few cases in which a string/number is used.
Member
|
Travis CI reports errors partially shown below: Ref: https://travis-ci.org/OpenAPITools/openapi-generator/builds/517324159 |
Member
What about updating the spec to specify the |
Contributor
Author
|
The spec in my issue uses openapi: 3.0.0 and specifies requestBody.content as a replacement of consumes. |
Contributor
Author
|
@wing328 All tests are passing now. |
Member
|
@sarod 👍 If no one has further feedback on this PR, I'll merge it on coming Friday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2623
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Accept body as bytes to support binary content types like application/octet-stream