Skip to content

[Ruby] Auto recreate specs in OAS3 Ruby sample#2264

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
autopp:auto-recreate-specs-in-oas3-ruby-sample
Feb 28, 2019
Merged

[Ruby] Auto recreate specs in OAS3 Ruby sample#2264
wing328 merged 2 commits intoOpenAPITools:masterfrom
autopp:auto-recreate-specs-in-oas3-ruby-sample

Conversation

@autopp
Copy link
Contributor

@autopp autopp commented Feb 28, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

Description of the PR

In order to guarantee update of test files in sample for Ruby's OAS3 client (samples/openapi3/client/petstore/ruby/spec), bin/openapi3/ruby-client-petstore.sh will also purge the test file.

See: #2211 (comment)

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 added this to the 4.0.0 milestone Feb 28, 2019
@wing328 wing328 merged commit 84b99fe into OpenAPITools:master Feb 28, 2019
@autopp autopp deleted the auto-recreate-specs-in-oas3-ruby-sample branch February 28, 2019 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants