[Go] validate required fields when unmarshalling JSON#16863
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Nov 4, 2023
Merged
[Go] validate required fields when unmarshalling JSON#16863wing328 merged 3 commits intoOpenAPITools:masterfrom
wing328 merged 3 commits intoOpenAPITools:masterfrom
Conversation
268ecb5 to
a5fc00e
Compare
Member
Member
|
can you please take a look at the CI failure when you've time? |
04c8426 to
209e5a0
Compare
ctreatma
commented
Oct 19, 2023
f1c8b9e to
01479c4
Compare
Contributor
Author
|
@wing328 I updated the PR to only generate the |
Member
|
overall it looks good. when you've time, can you please PM me via Slack for a few quick questions/feedback? |
01479c4 to
e9b4247
Compare
e9b4247 to
e0ac538
Compare
This was referenced Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #12201
Code generated by the Go client generator does not validate
requiredfields, which is especially problematic inoneOfschemas where the sub-schemas are differentiated by required fields.For example, consider the following schema:
Assume that the API itself only returns an object that has
fooor an object that hasbar; it will not return an object with both properties. Existing versions ofopenapi-generatorGo client generator will generate models that do not enforce required properties; as a result, any attempt to use theThingmodel will result in an error likeError when calling <something>: data matches more than one schema in oneOf(Thing).This PR replicates the required field validation that exists in the
okhttp-gsongenerator:PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)