PHP - Permit to customize more composer.json parts#16012
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Jul 12, 2023
Merged
PHP - Permit to customize more composer.json parts#16012wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
wing328
reviewed
Jul 8, 2023
| ], | ||
| "homepage": "https://openapi-generator.tech", | ||
| "license": "unlicense", | ||
| "homepage": "{{artifactUrl}}", |
Member
There was a problem hiding this comment.
please use {{{ ... }}} instead of {{ ... }}, which outputs HTML escaped value.
Member
There was a problem hiding this comment.
will take care of it after merging this PR into master
wing328
reviewed
Jul 12, 2023
...s/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractPhpCodegen.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first PR. It's a WIP PR I think but it mainly to get some insights on it.
Fix #14645
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)