Fix cli options use tags and api name suffix#15936
Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom Jul 2, 2023
MelleD:fix-use-tags-cli-option
Merged
Fix cli options use tags and api name suffix#15936wing328 merged 5 commits intoOpenAPITools:masterfrom MelleD:fix-use-tags-cli-option
wing328 merged 5 commits intoOpenAPITools:masterfrom
MelleD:fix-use-tags-cli-option
Conversation
madalingavrilescu
approved these changes
Jun 27, 2023
welshm
approved these changes
Jun 27, 2023
| } | ||
| name = sanitizeName(name); | ||
| return camelize(name) + "Api"; | ||
| return camelize(name) + apiNameSuffix; |
Contributor
There was a problem hiding this comment.
Note: This will impact all spring code gen, not just cloud.
Contributor
Author
There was a problem hiding this comment.
Yes but the default is "Api", correct? So nothing should happen for the other ones. The tests said it's okay :P
I think it make sense also for the other spring generator to add a name suffix if you want. Nothing special to spring-cloud
borsch
approved these changes
Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
useTagCLI options is currently not used for the library spring cloud for the code generation. This PR fix this issue, what is a breaking change for the spring cloud generator, since the default value is currently always 'false'.In addition, the api name suffix option is now used. This is optional because the default "Api" is still set.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09)