Skip to content

[groovy] support enum generation in groovy client#15619

Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom
dyadyaJora:for-14420
May 24, 2023
Merged

[groovy] support enum generation in groovy client#15619
wing328 merged 5 commits intoOpenAPITools:masterfrom
dyadyaJora:for-14420

Conversation

@dyadyaJora
Copy link
Contributor

Description

Adds enum generation instead of empty classes in groovy client. This problem could be fixed using new template with -t params, but I found an issue #14420 and decided to open this PR.

Changes:

  • model: added generation of enums in separate classes and nested enums
  • ApiUtils: added custom request encoder. JsonGenerator in groovy allows by default usage of Enum.name() instead of value field. groovyx.net.http.HttpBuilder does not support customizing of JsonGenerator, but it supports overriding of encoder.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented May 24, 2023

test passed: https://github.com/OpenAPITools/openapi-generator/actions/runs/5062525254/jobs/9094341663?pr=15619

let's give it a try.

thanks for the PR.

@wing328 wing328 merged commit 5b5cb1f into OpenAPITools:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants