Skip to content

[kotlin] New 'jvm-spring-webclient' library#15568

Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom
stefankoppier:kotlin-client-spring-webclient
May 23, 2023
Merged

[kotlin] New 'jvm-spring-webclient' library#15568
wing328 merged 5 commits intoOpenAPITools:masterfrom
stefankoppier:kotlin-client-spring-webclient

Conversation

@stefankoppier
Copy link
Contributor

@stefankoppier stefankoppier commented May 18, 2023

New 'jvm-spring-webclient' library aiming to resolve issue 15320.

It's a first "basic" implementation with the desire to continue expanding it, and possibly other aspects of the kotlin generators. The main things to review are those in libraries/jvm-spring-webclient, KotlinClientCodegen with the result in the sample folder kotlin-jvm-spring-webclient.

Kotlin technical committee: @jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m

@stefankoppier stefankoppier changed the title New 'jvm-spring-webclient' library for kotlin-client [kotlin] New 'jvm-spring-webclient' library May 18, 2023
wing328
wing328 reviewed May 19, 2023
View reviewed changes
wing328
wing328 reviewed May 19, 2023
View reviewed changes
@stefankoppier stefankoppier requested a review from wing328 May 19, 2023 05:51
@wing328 wing328 added this to the 7.0.0 milestone May 23, 2023
@wing328
Copy link
Member

wing328 commented May 23, 2023

Tested locally and the result is also good:

Starting a Gradle Daemon (subsequent builds will be faster)

> Task :compileKotlin
w: /private/tmp/kotlin-client/src/main/kotlin/org/openapitools/client/apis/PetApi.kt: (144, 16): 'findPetsByTagsWithHttpInfo(List<String>): Mono<ResponseEntity<List<Pet>>>' is deprecated. This operation is deprecated.
w: /private/tmp/kotlin-client/src/main/kotlin/org/openapitools/client/apis/PetApi.kt: (151, 35): 'findPetsByTagsRequestConfig(List<String>): RequestConfig<Unit>' is deprecated. This operation is deprecated.

BUILD SUCCESSFUL in 1m 26s
3 actionable tasks: 3 executed

@wing328 wing328 merged commit 9358ab9 into OpenAPITools:master May 23, 2023
@wing328
Copy link
Member

wing328 commented May 23, 2023

@stefankoppier thanks for the PR, which has been merged.

@stefankoppier
Copy link
Contributor Author

stefankoppier commented May 23, 2023

@stefankoppier thanks for the PR, which has been merged.

Thanks @wing328

@wing328
Copy link
Member

wing328 commented May 23, 2023

FYI. Just merged #15608 with some minor enhancements

@stefankoppier stefankoppier deleted the kotlin-client-spring-webclient branch June 2, 2023 09:33
@MatthiasGabriel MatthiasGabriel mentioned this pull request Dec 13, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimschubert jimschubert Awaiting requested review from jimschubert

@wing328 wing328 Awaiting requested review from wing328

Assignees

No one assigned

Labels

Client: Kotlin Enhancement: New generator

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

[REQ][Kotlin] Add spring webclient library

2 participants

@stefankoppier @wing328