[Go] Update API naming to follow Golang standard pkg (1 line change)#15331
Merged
wing328 merged 9 commits intoOpenAPITools:masterfrom May 13, 2023
Merged
[Go] Update API naming to follow Golang standard pkg (1 line change)#15331wing328 merged 9 commits intoOpenAPITools:masterfrom
wing328 merged 9 commits intoOpenAPITools:masterfrom
Conversation
Member
|
CircleCI failure not related to this change. |
Member
|
LGTM. Let's give it a try. In case users need to fall back to |
Member
|
FYI. Merged #15505 to fix tests |
1 task
|
@wing328 it took us quite a while to find this discussion and learn about ? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the naming conventions of Go standard packages, Acronyms should be all caps.
Api thus should be API instead
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)