Skip to content

[Fix] take referenced types into account for enum defaults (fixes #14689)#14692

Closed
robbertvanwaveren wants to merge 1 commit intoOpenAPITools:masterfrom
robbertvanwaveren:fix-for-issue-14689
Closed

[Fix] take referenced types into account for enum defaults (fixes #14689)#14692
robbertvanwaveren wants to merge 1 commit intoOpenAPITools:masterfrom
robbertvanwaveren:fix-for-issue-14689

Conversation

@robbertvanwaveren
Copy link
Contributor

@robbertvanwaveren robbertvanwaveren commented Feb 14, 2023

Attempt to resolve a regression in 6.3.0 related to default's for referenced enums.

fixes #14689

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Feb 16, 2023

@robbertvanwaveren thanks for the PR. I will see if I can come up with a better fix.

@wing328
Copy link
Member

wing328 commented Feb 16, 2023

cc @OpenAPITools/generator-core-team

@robbertvanwaveren
Copy link
Contributor Author

superseded by #14882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] default values for references enums are not generated correctly

2 participants