Skip to content

[java] 14404 fix for json arrays#14405

Closed
ashatch wants to merge 1 commit intoOpenAPITools:masterfrom
ashatch:14404-java-arrays-processing-fix
Closed

[java] 14404 fix for json arrays#14405
ashatch wants to merge 1 commit intoOpenAPITools:masterfrom
ashatch:14404-java-arrays-processing-fix

Conversation

@ashatch
Copy link
Contributor

@ashatch ashatch commented Jan 9, 2023

Fix for #14404.

@wing328 hope this makes sense. Do you have guidance on any missing tests around this code? Thanks.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Jan 12, 2023

@ashatch thanks for the PR. Can you please PM me to further discuss the test when you've time?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@wing328 wing328 added this to the 6.3.0 milestone Jan 12, 2023
@wing328 wing328 modified the milestones: 6.3.0, 6.3.1 Jan 20, 2023
@wing328
Copy link
Member

wing328 commented Feb 3, 2023

@wing328 wing328 modified the milestones: 6.4.0, 6.5.0 Feb 19, 2023
@wing328 wing328 modified the milestones: 6.5.0, 6.6.0 Apr 1, 2023
@wing328 wing328 modified the milestones: 6.6.0, 7.0.0 May 11, 2023
@wing328 wing328 modified the milestones: 7.0.0, 7.0.1 Aug 25, 2023
@wing328 wing328 modified the milestones: 7.0.1, 7.1.0 Sep 19, 2023
@wing328 wing328 modified the milestones: 7.1.0, 7.2.0 Nov 13, 2023
@wing328 wing328 modified the milestones: 7.2.0, 7.3.0 Dec 22, 2023
@wing328
Copy link
Member

wing328 commented Jan 27, 2024

closing it as there's no update.

@wing328 wing328 closed this Jan 27, 2024
@vasiliisorokin vasiliisorokin mentioned this pull request Feb 7, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants