[Ktor] Update generator to latest Ktor version #14061#14296
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom May 21, 2023
Merged
[Ktor] Update generator to latest Ktor version #14061#14296wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
Member
|
@rsinukov thanks for the PR. Will merge when we're approaching the 7.0.0 release. |
Member
|
can you please resolve the merge conflicts when you've time? thank you |
dd9a109 to
5c55e30
Compare
Author
|
@wing328 done! |
5c55e30 to
431275c
Compare
Member
|
LGTM. Thanks for the PR 👍 |
|
just fyi, the docs still say 1.67. I was bummed for a sec but then I tested it and saw 2.1.3. Thank you so much for updating to ktor 2!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14061
This is a breaking change, so I opened this PR into 7.0.x branch.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m