[Java] fix additional annotations for oneOf interfaces#13958
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Nov 20, 2022
Merged
Conversation
welshm
approved these changes
Nov 10, 2022
Contributor
welshm
left a comment
There was a problem hiding this comment.
I think this is fine and allows for flexibility over the alternative of removing
|
Just ran into this issue; looking forward to the fix and its release |
Member
Author
|
@wing328 could you please review & merge this one? |
cachescrubber
approved these changes
Nov 18, 2022
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #13917
Note: minimal required fix for above issue is to remove
additionalModelTypeAnnotationsfromoneofinterface.What I did is that I've introduced one more configuration option
additionalOneOfTypeAnnotationswhich can be used to configure common marked annotations forOneOfBase interfacesJava/Spring tech committee, what do you think about this? Just remove
additionalModelTypeAnnotationsfrom oneof interface or remove + add new option specific to oneof interfaces?PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)