Skip to content

[Java] fix additional annotations for oneOf interfaces#13958

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
borsch:fix-additional-annotations-for-oneof-interfaces
Nov 20, 2022
Merged

[Java] fix additional annotations for oneOf interfaces#13958
wing328 merged 1 commit intoOpenAPITools:masterfrom
borsch:fix-additional-annotations-for-oneof-interfaces

Conversation

@borsch
Copy link
Member

@borsch borsch commented Nov 8, 2022

Fix for #13917

Note: minimal required fix for above issue is to remove additionalModelTypeAnnotations from oneof interface.
What I did is that I've introduced one more configuration option additionalOneOfTypeAnnotations which can be used to configure common marked annotations for OneOf Base interfaces

Java/Spring tech committee, what do you think about this? Just remove additionalModelTypeAnnotations from oneof interface or remove + add new option specific to oneof interfaces?

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
Java @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)
Java Spring @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09)

Copy link
Contributor

@welshm welshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine and allows for flexibility over the alternative of removing

@tacotown
Copy link

Just ran into this issue; looking forward to the fix and its release

@borsch
Copy link
Member Author

borsch commented Nov 18, 2022

@wing328 could you please review & merge this one?

@wing328 wing328 merged commit 95b566a into OpenAPITools:master Nov 20, 2022
@wing328 wing328 added this to the 6.3.0 milestone Nov 20, 2022
@borsch borsch deleted the fix-additional-annotations-for-oneof-interfaces branch November 20, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants