Skip to content

[kotlin][client] add support for unknown default case with Kotlinx Serialization#12930

Merged
4brunu merged 9 commits intoOpenAPITools:masterfrom
4brunu:feature/kotlinx-serialization-unkown-enum-case
Jul 26, 2022
Merged

[kotlin][client] add support for unknown default case with Kotlinx Serialization#12930
4brunu merged 9 commits intoOpenAPITools:masterfrom
4brunu:feature/kotlinx-serialization-unkown-enum-case

Conversation

@4brunu
Copy link
Contributor

@4brunu 4brunu commented Jul 19, 2022

This PR adds support for unknown default case with Kotlinx Serialization.

It's a continuation of #11078

This PR also fixes some non public visibility issues and improves the kotlinx serialization serializer, renaming it from jvmJson to KotlinxSerializationJson, but keeping it backwards compatible with a warning and a rename action.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03)

@4brunu
Copy link
Contributor Author

4brunu commented Jul 24, 2022

@wing328 hey, when you have some time could you please take a look at this? Thanks 🙂

@4brunu 4brunu merged commit 87dc757 into OpenAPITools:master Jul 26, 2022
@4brunu 4brunu deleted the feature/kotlinx-serialization-unkown-enum-case branch July 26, 2022 08:42
@wing328 wing328 added this to the 6.1.0 milestone Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants