Skip to content

feat(rust): allow more granular Rust integer types and cleaned up clippy warnings#12479

Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom
BrightDotAi:master
Jul 9, 2022
Merged

feat(rust): allow more granular Rust integer types and cleaned up clippy warnings#12479
wing328 merged 5 commits intoOpenAPITools:masterfrom
BrightDotAi:master

Conversation

@thrykol
Copy link
Contributor

@thrykol thrykol commented May 26, 2022

  • Added CLI option to down cast integers to their best fit
    • Will only occur when minimum and maximum are both set
    • Configuration defaults to false
  • Added CLI option to prefer unsigned integers
    • Will only occur when minimum is defined and non-negative
    • Configuration defaults to false
  • toParamName now lower cases to adhere to rustfmt
    • Previously, the tail component of $ref was being upper cased
  • Added unit tests around all new features

@frol
@farcaller
@richardwhiuk
@paladinzh

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
  • File the PR against the correct branch: master (6.0.1) (patch release), 6.1.x (breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 6.1.0 milestone Jul 9, 2022
@wing328
Copy link
Member

wing328 commented Jul 9, 2022

LGTM. Thanks for the enhancement.

@wing328 wing328 merged commit a1892b1 into OpenAPITools:master Jul 9, 2022
@spacether
Copy link
Contributor

spacether commented Jul 9, 2022

Sample up to date test failed in CI for this PR

@spacether
Copy link
Contributor

spacether commented Jul 9, 2022

I am fixing it in:
#12817

wing328
wing328 reviewed Jul 10, 2022
View reviewed changes
...es/openapi-generator/src/main/java/org/openapitools/codegen/languages/RustClientCodegen.java
public String toParamName(String name) {
return toVarName(name);
// $ref appears to be all uppercase which is contrary to rustfmt practice so lowercase parameters
return toVarName(name.toLowerCase(Locale.ROOT));
Copy link
Member

@wing328 wing328 Jul 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This result in change of variable name (e.g. pet_id => petid): https://github.com/OpenAPITools/openapi-generator/pull/12817/files

I'll file a PR to fix it by remove https://github.com/OpenAPITools/openapi-generator/pull/12479/files#diff-8daa2cc862ff0a63dd72dac551951b1bb07675e3cc0609a6dea55d2e85492520R440 instead.

Copy link
Member

@wing328 wing328 Jul 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filed #12820

@wing328 wing328 mentioned this pull request Jul 10, 2022
Merged
5 tasks
@wing328
Copy link
Member

wing328 commented Jul 10, 2022

Thanks @spacether

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wing328 wing328 wing328 left review comments

Assignees

No one assigned

Labels

Client: Rust Enhancement: Feature

Projects

None yet

Milestone

6.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@thrykol @wing328 @spacether