[Php] Exclude query params when they're not required#12120
Merged
wing328 merged 15 commits intoOpenAPITools:masterfrom Apr 25, 2022
ksvirkou-hubspot:feature/emptyQueryParamIfNotRequired
Merged
[Php] Exclude query params when they're not required#12120wing328 merged 15 commits intoOpenAPITools:masterfrom ksvirkou-hubspot:feature/emptyQueryParamIfNotRequired
wing328 merged 15 commits intoOpenAPITools:masterfrom
ksvirkou-hubspot:feature/emptyQueryParamIfNotRequired
Conversation
update master
merge master
merge master
merge master
Contributor
Author
5 tasks
Member
Reported by https://github.com/OpenAPITools/openapi-generator/runs/5992057816?check_suite_focus=true For the typescript sample, it has been updated in the master. Please merge the latest master into your branch. |
Contributor
|
@ksvirkou-hubspot could you add a few tests? You've added new |
Contributor
Author
Will do |
Contributor
Author
Contributor
|
Hey team, any updates on merging this? |
Member
|
Just merged. Thanks @ksvirkou-hubspot for the PR. |
Contributor
|
Hey @ybelenko, sorry i never saw this one. But as along as it does not break your unit tests, this should not affect the deep object serialization. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exclude query params when they're not required
{ "name": "archived", "in": "query", "description": "Whether to return only results that have been archived.", "required": false, "style": "form", "explode": true, "schema": { "type": "boolean", "default": false } }if archived is empty
https://api.*.com/crm/v3/objects/contactsPR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.