Skip to content

Replace maps with models to reduce casting#11913

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
borsch:reduce-casting
Mar 24, 2022
Merged

Replace maps with models to reduce casting#11913
wing328 merged 2 commits intoOpenAPITools:masterfrom
borsch:reduce-casting

Conversation

@borsch
Copy link
Member

@borsch borsch commented Mar 18, 2022

Enhancement to reduce number of casting operations inside generators. If https://github.com/orgs/OpenAPITools/teams/generator-core-team are happy with change I'll do the same with operations

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@borsch borsch requested a review from jimschubert as a code owner March 18, 2022 19:36
@wing328
Copy link
Member

wing328 commented Mar 20, 2022

LGTM.

Can you please run ./bin/utils/ensure-up-to-date to fix https://github.com/OpenAPITools/openapi-generator/runs/5609854928?check_suite_focus=true ?

@wing328 wing328 added Feature: Generator Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Mar 20, 2022
@wing328 wing328 added this to the 6.0.0 milestone Mar 20, 2022
@borsch
Copy link
Member Author

borsch commented Mar 20, 2022

@wing328 thanks for review. I've update samples

@wing328
Copy link
Member

wing328 commented Mar 21, 2022

LGTM 👍

Will merge on Wed if no feedback or question from anyone.

cc @OpenAPITools/generator-core-team

@wing328
Copy link
Member

wing328 commented Mar 22, 2022

@borsch can you please resolve the merge conflicts when you've time?

…rator into reduce-casting

� Conflicts:
�	modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PythonExperimentalClientCodegen.java
@borsch
Copy link
Member Author

borsch commented Mar 23, 2022

@wing328 done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Feature: Generator

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants