fix(rust,client): re-enable TLS support for reqwest with supportAsync#10439
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Sep 22, 2021
Merged
fix(rust,client): re-enable TLS support for reqwest with supportAsync#10439wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
This avoids disabling TLS support entirely.
This avoids disabling TLS support entirely.
9 tasks
Member
|
Rust petstore tests passed via https://app.travis-ci.com/github/OpenAPITools/openapi-generator/builds/238202751 |
Member
|
LGMT. Thanks for the enhancement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing reqwest codegen disables the default reqwest crate features when
supportAsync=true: this inadvertently has the effect of disabling reqwest's TLS support entirely.This PR keeps the default features, which matches the behaviour of
supportAsync=false, and keeps the default TLS support enabled.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x@frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05)