Dart2 template linting#10263
Merged
wing328 merged 57 commits intoOpenAPITools:masterfrom Sep 13, 2021
noordawod:refactor/dart2-template-linting
Merged
Dart2 template linting#10263wing328 merged 57 commits intoOpenAPITools:masterfrom noordawod:refactor/dart2-template-linting
wing328 merged 57 commits intoOpenAPITools:masterfrom
noordawod:refactor/dart2-template-linting
Conversation
Bumps [jimschubert/query-tag-action](https://github.com/jimschubert/query-tag-action) from 1 to 2. - [Release notes](https://github.com/jimschubert/query-tag-action/releases) - [Commits](jimschubert/query-tag-action@v1...v2) Signed-off-by: dependabot[bot] <support@github.com>
…ubert/query-tag-action-2 Bump jimschubert/query-tag-action from 1 to 2
Contributor
Author
|
Anyone wants to take a look? |
Contributor
Author
|
At last, green! 🤟 |
Contributor
Author
|
Code is updated again with |
agilob
reviewed
Sep 3, 2021
modules/openapi-generator/src/main/resources/dart2/api_client.mustache
Outdated
Show resolved
Hide resolved
agilob
reviewed
Sep 3, 2021
modules/openapi-generator/src/main/resources/dart2/api_helper.mustache
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@agilob updated the code per your notes, ball's at your end. Thanks! |
agilob
approved these changes
Sep 4, 2021
Contributor
Author
|
@agilob you think it's possible to merge this pr this week? |
Contributor
|
@wing328 can we get this in pls? |
Contributor
Author
|
@wing328 maybe start the week with a positive merge vibes? :) |
Contributor
|
I would like this merged as it will conflict with my dart2 NNBD branch |
Contributor
|
Any comments from @kuhnroyal? |
Member
|
Just merged. Sorry for the delay. |
5 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been many changes lately for the Dart linter, particularly the
pedanticlinting has been phased out in favor offlutter_lints. For upgrade details: https://github.com/dart-lang/lints#migrating-from-packagepedanticAnyway, when I regenerated the source code using the current Dart template and using the linting rules that comes with
flutter_lints, I got many errors. In addition, I personally use a stricter linter rules and so I also added few ignore to silence the linter in such cases.In addition, there's no more need for implicit casting in the resulting source code and the
analysis_options.yamlcan practically be removed now.All in all, the generated code is much better now and will run in both
pedanticand the newflutter_lints.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m @wing328 @jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela