Enhancement/flake8 pipeline check#28
Merged
CheesyLaZanya merged 2 commits intoOpen-Model-Initiative:mainfrom Aug 19, 2024
Merged
Conversation
Signed-off-by: Prateek Kumar <85689959+PrateekKumar1709@users.noreply.github.com>
Signed-off-by: Prateek Kumar <85689959+PrateekKumar1709@users.noreply.github.com>
CheesyLaZanya
approved these changes
Aug 19, 2024
Collaborator
CheesyLaZanya
left a comment
There was a problem hiding this comment.
Workflow matches expectations and discussion.
Supposedly workflows not running on the initial PR from forked repos is expected so this should impact future PRs is my understanding.
So looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement:
The project needs to ensure code quality checks are performed in the GitHub pipeline, especially for pull requests, to catch issues that might be missed if local pre-commit hooks aren't run properly.
Related Issue:
Fixes #19 - Add flake8 check to the Github pipeline
Proposed Changes:
Create a new GitHub Actions workflow file (.github/workflows/flake8.yml) to run Flake8 checks on pull requests.
Testing:
The GitHub Actions workflow has been tested by creating a test pull request.