Build - Fix C++ standard options and NOMINMAX scope#907
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom Dec 12, 2025
Merged
Build - Fix C++ standard options and NOMINMAX scope#907dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
Conversation
Member
dpasukhi
commented
Dec 12, 2025
- Fix C++ standard dropdown: split "C++23 C++26" into separate options
- Move NOMINMAX define from MSVC-only to all WIN32 compilers
- Fix C++ standard dropdown: split "C++23 C++26" into separate options - Move NOMINMAX define from MSVC-only to all WIN32 compilers
There was a problem hiding this comment.
Pull request overview
This PR fixes two build configuration issues in the CMake setup: separating C++23 and C++26 into distinct dropdown options, and ensuring the NOMINMAX preprocessor definition applies to all Windows compilers rather than only MSVC.
Key changes:
- Split the combined "C++23 C++26" dropdown option into separate "C++23" and "C++26" options
- Move NOMINMAX definition from MSVC-specific section to a general WIN32 block to cover MinGW and other Windows compilers
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| CMakeLists.txt | Separates the C++ standard dropdown options for C++23 and C++26 |
| adm/cmake/occt_defs_flags.cmake | Removes NOMINMAX from MSVC-specific block and adds it to a new WIN32-specific block for broader Windows compiler support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.