Foundation Classes - Refactor BVH_Box to use generic vector types#858
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom Nov 26, 2025
Merged
Foundation Classes - Refactor BVH_Box to use generic vector types#858dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
Conversation
… add transformation tests
There was a problem hiding this comment.
Pull request overview
This PR refactors BVH_Box to use generic vector types instead of hard-coded Graphic3d_Vec3d and Graphic3d_Vec4d, enabling support for both single-precision (float) and double-precision (double) transformations. This change makes the Transform and Transformed methods properly templated to work with the box's precision type T.
Key Changes:
- Replaced
Graphic3d_Vec3dandGraphic3d_Vec4dwith genericBVH_VecNtandBVH::VectorType<T, 4>::Type - Changed
Standard_IntegerandStandard_Realto template typeTandintfor generic implementation - Added comprehensive test coverage for float-precision transformations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
BVH_Box.hxx |
Refactored Transformed method to use generic vector types and template parameter T instead of hard-coded double-precision types |
BVH_Box_Test.cxx |
Added 5 new test cases covering float-precision transform operations (identity, translation, scale) and edge cases |
AtheneNoctuaPt
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.