Skip to content

Coding - Rework of Math global functions to stl#833

Merged
dpasukhi merged 12 commits intoOpen-Cascade-SAS:IRfrom
AtheneNoctuaPt:rework_standard_real
Nov 17, 2025
Merged

Coding - Rework of Math global functions to stl#833
dpasukhi merged 12 commits intoOpen-Cascade-SAS:IRfrom
AtheneNoctuaPt:rework_standard_real

Conversation

@AtheneNoctuaPt
Copy link
Copy Markdown
Collaborator

Majority of fuctions now simply call same functions from std namespace. Functions that duplicate std namespace functionality are declared depricated.
Calls of depricated functions are replaced with std functions calls.

@AtheneNoctuaPt AtheneNoctuaPt added 2. Enhancement New feature or request 1. Foundation Classes Containers, system calls wrappers, smart pointers and other low level of OCCT code labels Nov 14, 2025
@dpasukhi dpasukhi requested a review from Copilot November 15, 2025 09:38
@dpasukhi dpasukhi added this to the Release 8.0 milestone Nov 15, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@dpasukhi
Copy link
Copy Markdown
Member

dpasukhi commented Nov 15, 2025

Full testing has no regression.
But for now I would like to ask to migrate the custom code with
if (magic number) to some helper, to resovle it in the future. Or maybe use old version for now.
@AtheneNoctuaPt

@dpasukhi dpasukhi requested a review from Copilot November 15, 2025 11:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@dpasukhi dpasukhi requested a review from Copilot November 16, 2025 08:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Member

@dpasukhi dpasukhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godspeed!

@github-project-automation github-project-automation bot moved this from Todo to Integration in Maintenance Nov 17, 2025
@dpasukhi dpasukhi changed the title Rework of Standard_Real.h/.cpp Coding - Rework of Math global function to stl Nov 17, 2025
@dpasukhi dpasukhi requested a review from Copilot November 17, 2025 13:28
@dpasukhi dpasukhi changed the title Coding - Rework of Math global function to stl Coding - Rework of Math global functions to stl Nov 17, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@dpasukhi dpasukhi merged commit c479f6e into Open-Cascade-SAS:IR Nov 17, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from Integration to Done in Maintenance Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1. Foundation Classes Containers, system calls wrappers, smart pointers and other low level of OCCT code 2. Enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants